[QNN EP] Re-enable several disabled QNN-EP UTs #23799
Open
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description
1. Re-enable UTs which passed 2.30
2. Fix conv and resize UTs
- Make conv's weight as initializer to let graph.NumberOfNodes()
match ep_nodes, which should be 1.
- Update resize UT because "round_prefer_floor" is no longer
supported in QNN SDK since 2.21.
### Motivation and Context
1. Make the UT of QNN EP pass as much as possible to improve the test
coverage.
|
@microsoft-github-policy-service agree company="Qualcomm" |
HectorSVC
reviewed
Feb 24, 2025
| TestInputDef<float> input_def({1, 2, 5, 5}, false, GetFloatDataInRange(-10.0f, 10.0f, 50)); | ||
| TestInputDef<float> weight_def({1, 2, 3, 3}, false, GetFloatDataInRange(-1.0f, 5.0f, 18)); | ||
| TestInputDef<float> weight_def({1, 2, 3, 3}, true, GetFloatDataInRange(-1.0f, 5.0f, 18)); |
There was a problem hiding this comment.
Does that mean for some Conv case, the weight has to be static? Should we identify such cases and do the validation in ConvOpBuilder in QNN EP to place these nodes on CPU EP instead of QNN EP?
|
/azp run Linux QNN CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Linux Android Emulator QNN CI Pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context